Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create query_adverbs.sparql #374

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

Otom-obhazi
Copy link
Contributor

Adverb for Basque

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Adverb for Basque
Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@Otom-obhazi: Are you checking for the forms for the adverbs? Please stop sending pull requests if all you're doing is copying the file and changing the language QID. Yes this is a contribution, but when I'm asking you to work on your current PRs to expand them and then you just send more of the same it's actually disruptive. If you're still unsure of how to check forma and expand them, then ask myself or other contributors.

@Otom-obhazi
Copy link
Contributor Author

@andrewtavis i dont understand what you mean by checking forma and expanding them.

@andrewtavis
Copy link
Member

I'm happy to explain, and please let me know that it's still confusing as you have just now rather than continuing to work. I'm wiring out a more detailed explanation now :)

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 15, 2024 via email

@andrewtavis
Copy link
Member

To expand on my explanation that I sent along here:

  • Let's take for example the query for Slovak adjectives src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql
  • Let's take this query over to query.wikidata.org, but with one edit to return to lexeme URI via ?lexeme
    • You can see the edited query in the Wikidata Query Service here
    • Note that it includes ?lexeme
  • Run the query and look at the results
  • Click on the first result, which will be random, and for me was wikidata.org/wiki/Lexeme:L238355
    • This is the Slovak adjective slovenský (the adjective conveniently means Slovak)
    • This is the base adjective, but in Slovak specifically we need to also get forms for the adjectives as they're different based on if the thing is masculine, feminine, etc
    • You can see all of these other forms on the Wikidata page when you scroll down
    • There are forms based on masculine vs. feminine, singular vs. plural and the case that's used
    • These are the forms that we also want to include in our data outputs
  • Some of the queries you've sent along don't have forms, so they're fine, but we need to check for the forms before sending them along
  • An example of a query for adverbs with tons of forms is src/scribe_data/language_data_extraction/Estonian/adverbs/query_adverbs_1.sparql
    • Slovak is similar to Estonian in these regards, that there are many forms and they're complex
    • We need to construct forms with an optional selection that includes all the properties that are on the form
    • For the first form above slovenský we need to find the Wikidata QIDs for masculine, nominative case, singular, positive
    • Then put these within the optional selection to get the form in a way that the returned value is unique

I'll go through now and merge in the PRs that don't have forms. This could be all of them or none of them, but I really would ask that you check for these things beforehand. The Estonian query for instance is dramatically more valuable because it includes all of its forms :)

Let me know if there are further questions! I really appreciate your interest in the project. I hope you understand that I really needed you to pause for a moment so I could explain some things to you so that you can have a better impact on the project 😊

@andrewtavis
Copy link
Member

please can you help me with resources too..
thank you

What do you mean by resources?

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 15, 2024 via email

@andrewtavis
Copy link
Member

You can check the following:

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar for this one, let's be sure to have all directories be lower case except for Languages, @Otom-obhazi :)

@andrewtavis
Copy link
Member

Thanks for the help!

@andrewtavis andrewtavis merged commit ae55b8a into scribe-org:main Oct 15, 2024
3 checks passed
@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 16, 2024 via email

@Otom-obhazi
Copy link
Contributor Author

Otom-obhazi commented Oct 16, 2024 via email

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants